Skip to content

Conversation

@willcohen
Copy link
Contributor

Not sure if you all are waiting on anything else for 3.6.1, but the updated polyfill algorithm seems to be working well here:

PolyfillBenchmark using core v3.6.0:

Benchmark                                         Mode  Cnt    Score   Error  Units
PolyfillBenchmark.benchmarkPolyfill              thrpt   20  645.709 ± 5.664  ops/s
PolyfillBenchmark.benchmarkPolyfillWithHole      thrpt   20  645.329 ± 2.836  ops/s
PolyfillBenchmark.benchmarkPolyfillWithTwoHoles  thrpt   20  640.004 ± 2.311  ops/s

PolyfillBenchmark using core v.3.6.1:

Benchmark                                         Mode  Cnt    Score   Error  Units
PolyfillBenchmark.benchmarkPolyfill              thrpt   20  735.690 ± 1.908  ops/s
PolyfillBenchmark.benchmarkPolyfillWithHole      thrpt   20  684.496 ± 2.169  ops/s
PolyfillBenchmark.benchmarkPolyfillWithTwoHoles  thrpt   20  641.440 ± 1.687  ops/s

@dfellis
Copy link
Collaborator

dfellis commented Nov 14, 2019

Not waiting on anything, the usual maintainer is on a break right now and it slipped our minds (and I think @nrabinowitz is the only one with commit access here not on break?)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 188

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.49%

Totals Coverage Status
Change from base Build 183: 0.0%
Covered Lines: 390
Relevant Lines: 392

💛 - Coveralls

@nrabinowitz
Copy link
Contributor

Thanks for submitting! The change looks good and I'm happy to merge, but I'll need to bring in @boyxgc to actually publish the library.

@nrabinowitz nrabinowitz requested a review from boyxgc November 14, 2019 22:30
@nrabinowitz nrabinowitz merged commit b75c6cd into uber:master Nov 15, 2019
@willcohen
Copy link
Contributor Author

Thanks for all of your work on h3!

@willcohen willcohen deleted the core-3.6.1 branch November 15, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants