feat(agent): emit download counter for blob download qps#588
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Anton-Kalpakchiev
left a comment
Anton-Kalpakchiev
left a comment
There was a problem hiding this comment.
When the container runtime downloads an image, it:
- downloads the manifest from kraken-agent.
- if it's a manifest list (multi-arch manifest), it downloads the arch manifest separately
- downloads each image layer of the image
Does this metric track only 3) or does it increase upon 1 and 2? Do we perhaps want a separate metric for 1) and 2) or should we have a combined metric?
Collaborator
Author
|
It is placed at the blob level, so it will be triggered for both manifests and layers. By including both, we can obtain a more accurate QPS metric that reflects all blobs being downloaded. WDYT? @Anton-Kalpakchiev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a download counter to the read-only transferer to improve agent observability by being able to track its download QPS.