fix(blobrefresh): deduplicate download requests for blobs under different namespaces#610
Merged
Merged
Conversation
…er different namespaces
sambhav-jain-16
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When origin downloads blobs from GCS, it deduplicates simultaneous downloads for the same blob to avoid extra load. It deduplicates based on an
iddefined to be the blob's namespace + digest. However, this is wrong - if the same blob is being requested under 2 different namespaces, it will have 2 different IDs and deduplication will fail. This PR fixes that by changing theidof a download blob request to be the blob's digest, instead of namespace+digest. I also add a unit test that would have caught the bug.This issue has been happening for 8+ years, but we just caught it because of this log message.