React 16 #15
Merged
React 16 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
johnvf
suggested changes
Oct 16, 2017
Contributor
johnvf
left a comment
johnvf
left a comment
There was a problem hiding this comment.
Can you update the major version (EG - bump to 2.0.0), since bumping React is going to be a breaking change for folks on React 15?
Contributor
Author
Have bumped to 2.0. I can't think why it wouldn't work with react 15 although I imagine it would put up a peer dependency warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bare minimum to get this running with a React 16 project.
yarn upgrade --latest)react,react-domto React 16 (yarn add react react-dom --latest)prop-typesdependency needed for React 16 and migrated code to use itrefssyntax as existing was using deprecated strings andthis.refsThis works in the example.
I haven't updated the tests as they're using a very old style I'm unfamiliar with that will take a lot to migrate for the amount of test code.