Skip to content

implement change provider#141

Merged
behinddwalls merged 4 commits into
mainfrom
rprithyani/implementChangeProvider
Mar 13, 2026
Merged

implement change provider#141
behinddwalls merged 4 commits into
mainfrom
rprithyani/implementChangeProvider

Conversation

@rashmi-prithyani
Copy link
Copy Markdown
Contributor

@rashmi-prithyani rashmi-prithyani commented Mar 12, 2026

Summary

The orchestrator can now fetch rich metadata about a code change directly from GitHub — including the author, changed files (with line-level add/delete/modify counts and patches), and the head commit SHA — at validation time. This gives downstream controllers the information they need to make decisions based on what a PR actually touches, rather than just its identity.

The implementation supports stacked PRs by returning one ChangeInfo per URI in a Change, and handles large PRs transparently via GraphQL pagination. Authentication and endpoint configuration are injected via environment variables, making it compatible with both github.com and GitHub Enterprise.

Test Plan

Unit tests cover Client URL construction, GraphQL pagination, URI validation, and provider behavior with a mock HTTP server.

Issues

@rashmi-prithyani rashmi-prithyani force-pushed the rprithyani/implementChangeProvider branch 2 times, most recently from d7a7fd0 to 786d46c Compare March 12, 2026 20:36
@rashmi-prithyani rashmi-prithyani force-pushed the rprithyani/implementChangeProvider branch from 786d46c to 50e8544 Compare March 12, 2026 20:45
@rashmi-prithyani rashmi-prithyani marked this pull request as ready for review March 12, 2026 20:46
…ration

- Add ChangeProvider interface and GitHub implementation
- Use Client wrapper pattern with configurable auth
- Add tests for the change provider
@rashmi-prithyani rashmi-prithyani force-pushed the rprithyani/implementChangeProvider branch from 50e8544 to d12205d Compare March 12, 2026 20:49
Comment thread core/httpclient/transport.go Outdated
@rashmi-prithyani rashmi-prithyani force-pushed the rprithyani/implementChangeProvider branch from 533ff1f to c9eac59 Compare March 13, 2026 04:52
Comment thread core/httpclient/transport.go Outdated
Comment thread core/httpclient/transport.go Outdated
Comment thread core/httpclient/transport.go
@rashmi-prithyani rashmi-prithyani force-pushed the rprithyani/implementChangeProvider branch from 22e4e64 to 008f7d2 Compare March 13, 2026 06:17
@behinddwalls behinddwalls added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit ea93c6b Mar 13, 2026
13 checks passed
@github-actions github-actions Bot deleted the rprithyani/implementChangeProvider branch March 13, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants