fix(ci+orchestrator): unblock startup without PUSHER_CHECKOUT_PATH; harden required-checks gate#153
Merged
Merged
Conversation
…arden required-checks gate The merge_group CI run for PR #151 actually failed (e2e + orchestrator integration tests), but the PR merged anyway because the Required Checks aggregator job was *skipped* (its needs failed), and GitHub treats a skipped required status check as not-failed. Three fixes: 1. example/server/orchestrator/main.go: when PUSHER_CHECKOUT_PATH is unset, log a warning and fall back to an in-file noopPusher (returns an error on Push). Lets the orchestrator start in ping-only test environments and local dev; the merge controller still surfaces loudly via nack/retry if a misconfigured prod deployment ever reaches it. 2. .github/workflows/ci.yml: add 'if: always()' to required-checks plus an explicit step that fails when any needs result is failure/cancelled/skipped, so the gate turns RED instead of being skipped. Includes toJSON(needs) in the failure log for triage. 3. .github/workflows/ci.yml: add a dynamic run-name so the Actions UI distinguishes 'PR-CI #<n>' / 'MergeQueue-CI' / 'Main-CI' runs at a glance. Co-Authored-By: Oz <oz-agent@warp.dev>
manjari25
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The merge-queue CI run for #151 actually failed (Orchestrator + E2E integration tests), but the PR merged anyway. Root cause: the
Required Checksaggregator job was skipped (itsneedsfailed and it had noif: always()), and GitHub treats a skipped required status check as not-failed, so the ruleset onmainlet it through.The orchestrator-service container itself was crashing on startup because #151 made
PUSHER_CHECKOUT_PATHa hard requirement, but neither docker-compose used by the integration / e2e tests sets it.What
example/server/orchestrator/main.go— whenPUSHER_CHECKOUT_PATHis unset, log a warning and fall back to an in-filenoopPusherthat errors onPush. Lets the orchestrator start in ping-only tests / local dev without a checkout; the merge controller treats the error as transient and nacks, so misconfigured prod deployments still surface loudly..github/workflows/ci.yml— Required Checks gate: addif: always()plus an explicit step that fails when anyneeds.*.resultisfailure/cancelled/skipped, so the gate turns RED instead of skipped.toJSON(needs)is dumped to the log so the offending child job is obvious..github/workflows/ci.yml— dynamicrun-name: the Actions UI now labels runs asPR-CI #<n>,MergeQueue-CI, orMain-CIdepending on trigger.Test Plan
bazel build --platforms=@rules_go//go/toolchain:linux_amd64 //example/server/orchestrator— passesbazel test //orchestrator/controller/merge:merge_test //extension/pusher/...— passesmake fmtis a no-op on the modified files (yamlfmt + gofmt clean)Co-Authored-By: Oz oz-agent@warp.dev