feat(orchestrator): wire BuildManager into the build controller#169
Closed
behinddwalls wants to merge 1 commit into
Closed
feat(orchestrator): wire BuildManager into the build controller#169behinddwalls wants to merge 1 commit into
behinddwalls wants to merge 1 commit into
Conversation
## Summary The build controller had a `TODO: Trigger CI build` and hard-coded an `Accepted` build. It now invokes `BuildManager.Trigger`: it assembles one `entity.BuildChange` per request in the batch (action `Validate`), triggers the build, and publishes a `Build` carrying the manager's returned ID and status to the buildsignal stage. The orchestrator wires the noop manager (`extension/build/noop`) as the pass-through default, so a land request now flows end-to-end through the build step (every build succeeds) until a real provider is configured. Build failure handling and polling of non-terminal (`Accepted`/`Running`) builds are deliberately out of scope here — the noop always returns a terminal status — and are left as follow-ups. ## Test Plan - ✅ \`make fmt && make lint\` - ✅ \`make check-gazelle && make check-tidy && make check-mocks\` - ✅ \`bazel build //...\` - ✅ \`bazel test //... --test_tag_filters=-integration\` — 36/36 - ⏭️ \`make e2e-test\` requires Docker; not run in this environment ## Issues (none)
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The build controller had a
TODO: Trigger CI buildand hard-coded anAcceptedbuild. It now invokesBuildManager.Trigger: it assembles oneentity.BuildChangeper request in the batch (actionValidate), triggersthe build, and publishes a
Buildcarrying the manager's returned ID andstatus to the buildsignal stage. The orchestrator wires the noop manager
(
extension/build/noop) as the pass-through default, so a land request nowflows end-to-end through the build step (every build succeeds) until a real
provider is configured.
Build failure handling and polling of non-terminal (
Accepted/Running)builds are deliberately out of scope here — the noop always returns a
terminal status — and are left as follow-ups.
Test Plan
Stack