docs(storage): clarify BatchDependentStore invariant and Get semantics#178
Merged
Conversation
Document on the interface that every active Batch has a paired BatchDependent row (Create runs before BatchStore.Create), so Get only sees IDs from the active set and ErrNotFound is an invariant violation rather than an expected outcome. Also note that an empty Dependents list is the normal "no dependents" result. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
|
behinddwalls
approved these changes
Jun 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
signed CLA but GH does not pick up. Bypassing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BatchDependentStoreinterface that every activeBatchhas a pairedBatchDependentrow, since the batch-creation flow callsCreatehere before creating theBatchitself.Getis only called for batch IDs returned from the active-batch set, soErrNotFoundis part of the contract for completeness but signals an invariant violation rather than an expected outcome.Getthat an emptyDependentslist is the normal "no dependents" result.Test plan