test(storage): Replace handwritten storage mocks with gomock bazel rule#79
Merged
Conversation
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
manjari25
force-pushed
the
manjari/gomock-for-storage
branch
2 times, most recently
from
399a6d9 to
62f47bd
Compare
manjari25
force-pushed
the
manjari/gomock-for-storage
branch
from
bec50a3 to
1d77cf8
Compare
sbalabanov
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test(storage): Replace handwritten storage mocks with gomock bazel rule
What?
Replace handwritten storage mocks in gateway/controller/land_test.go with generated mocks using gomock and the Bazel gomock rule. The mocks are generated at build time — no generated .go files are checked in.
Why?
Handwritten mocks have to be manually updated every time a storage interface changes. Using gomock with the Bazel gomock rule eliminates this maintenance burden and guarantees mocks stay in sync with interfaces automatically.
Test Plan
Issues