Fix AtomicInt usages of deprecated atomic APIs #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of iOS 10.0 and MacOS 10.12 the old `OSMemoryBarrier`, `OSAtomicCompareAndSwap64Barrier`, `OSAtomicIncrement64Barrier`, and `OSAtomicDecrement64Barrier, APIs are deprecated. The warnings suggested new APIs are C++ and are not accessible from Swift. `OSMemoryBarrier` can be directly replaced with `atomic_thread_fence(memory_order_seq_cst)` which is accessible from Swift. The rest of the suggested C++ APIs `atomic_fetch_add`, `atomic_fetch_sub`, and `atomic_compare_exchange_strong` are not accessible from Swift. This change creates a Objective-C wrapper for these C++ APIs, so Swift code can access them.
rudro
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of iOS 10.0 and MacOS 10.12 the old
OSMemoryBarrier,OSAtomicCompareAndSwap64Barrier,OSAtomicIncrement64Barrier, and `OSAtomicDecrement64Barrier, APIs are deprecated. The warnings suggested new APIs are C++ and are not accessible from Swift.OSMemoryBarriercan be directly replaced withatomic_thread_fence(memory_order_seq_cst)which is accessible from Swift.The rest of the suggested C++ APIs
atomic_fetch_add,atomic_fetch_sub, andatomic_compare_exchange_strongare not accessible from Swift. This change creates a Objective-C wrapper for these C++ APIs, so Swift code can access them.