Skip to content

Fix Carthage Build #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix Carthage Build #39

merged 1 commit into from
Oct 3, 2019

Conversation

@sbarow
Copy link
Contributor

@sbarow sbarow commented Oct 2, 2019

  • Adds a Bridging Header to the project allowing Carthage to build the project.

Fixes #35

rudro
rudro approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@rudro rudro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love reviewing .pbxproj changes :p. Thanks, this looks good to me.

@sbarow sbarow merged commit 9b1a09d into uber:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rudro rudro rudro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to build using Carthage since 0.6.5

2 participants

@sbarow @rudro