Skip to content

Conversation

@sbarow
Copy link
Contributor

@sbarow sbarow commented May 21, 2018

When using 0.2.0 release with Carthage the user will receive an error, this diff updates the version to reflect the latest release.

*** Skipped building swift-concurrency due to the error:
Dependency "swift-concurrency" has no shared framework schemes for any of the platforms: iOS

Tested with 0.3.0 and works correctly with Carthage

Added IPHONEOS_DEPLOYMENT_TARGET and set it to 8.0.0 (this version should be fine right?)

@CLAassistant
Copy link

CLAassistant commented May 21, 2018

CLA assistant check
All committers have signed the CLA.

@sbarow sbarow changed the title Update README.md to show v0.3.0 for Carthage Add IPHONEOS_DEPLOYMENT_TARGET & Update README.md May 21, 2018
@sbarow sbarow changed the title Add IPHONEOS_DEPLOYMENT_TARGET & Update README.md Add IPHONEOS_DEPLOYMENT_TARGET & Update README.md May 21, 2018
README.md Outdated

```ogdl
github "https://github.com/uber/swift-concurrency.git" ~> 0.2.0
github "https://github.com/uber/swift-concurrency.git" ~> 0.3.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update to version 0.4.0 please?

@sbarow
Copy link
Contributor Author

sbarow commented May 25, 2018

@neakor done.

@neakor
Copy link
Contributor

neakor commented May 25, 2018

Thank you!

@sbarow
Copy link
Contributor Author

sbarow commented May 29, 2018

@neakor I don't have write access to this repo, so you'll have to do the merge :-)

@neakor
Copy link
Contributor

neakor commented May 29, 2018

Oh sorry haha! Thanks again.

@neakor neakor merged commit 5cc8829 into uber:master May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants