Additional metrics to graph runner#101
Merged
Merged
Conversation
xytan0056
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a tally.Scope to nativeGraphRunner so it can emit M3 metrics. Three new timers and a gauge are recorded on every Compute call:
The scope is inherited from the orchestrator's existing tally scope, so metrics surface as tango.orchestrator.graph_runner.* in M3. NativeGraphRunnerParams gained a Scope tally.Scope field (defaults to noop if nil).
b.scope is now passed to NativeGraphRunnerParams.Scted to the real tally reporter in production.
HashRuleCommon was being called twice per rule targ
Fix: removed target.HashWithoutDeps = []byte{} fromget.Hash needs to be the sentinel), thenHashRecursively reads target.HashWithoutDeps directly instead of re-running HashRuleCommon. A fallback still calls HashRuleCommon if HashWithoutDeps is somehow empty.