Filter changed targets and edges by distance#88
Merged
Conversation
GetChangedTargets filters changed_targets by output_config.max_distance when compute_distances is set, but GetChangedTargetsAndEdges did not, leaking distance=-1 targets and any target beyond the requested BFS bound. Extract the filter into shared helpers in distance_filter.go and apply it on both the cache-hit and compute paths of the edges endpoint. Added/removed targets and edges pass through unchanged — they represent graph topology deltas rather than BFS-ranked targets.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
xytan0056
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
GetChangedTargetsAndEdges response doesn't filter with distance, which differs from GetChangedTargets. It should filter by distance to match behaviors.
What?
Adds func sendWithDistanceFilterForEdges
Factors out common logic to distance_filter.go
Test Plan
distance 2 returns 30 targets
distance 1 returns 27 targets. Verified in the response that distance 2 targets are removed.
Issue