Clean up todos in codegen dir #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 31, 2018 12:05
herainman
reviewed
Aug 2, 2018
| s.RUnlock() | ||
| return fmt.Errorf("handler for '%s' is already registered", e.Method) | ||
| } | ||
| s.RUnlock() |
Contributor
There was a problem hiding this comment.
can we defer s.RUnlock? probably always need to unlock
Contributor
There was a problem hiding this comment.
there's another w-lock here :)
Contributor
Author
There was a problem hiding this comment.
As @cl1337 pointed out, deferring the rlock with cause the wlock to never succeed.
cl1337
approved these changes
Aug 2, 2018
|
|
||
| // Register registers the given TChannelEndpoint. | ||
| func (s *TChannelRouter) Register(e *TChannelEndpoint) { | ||
| func (s *TChannelRouter) Register(e *TChannelEndpoint) error { |
Contributor
There was a problem hiding this comment.
mm ... are we calling this multi-threading? thought Register is sequential in main
Contributor
Author
There was a problem hiding this comment.
Yes, Register is done in one goroutine, the locks in tchannel register is over kill for our use case, but since it's initialization only, so not a big deal.
herainman
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the todos in codegen dir except those related to type convertor and middlewares. Relates to #411.