Skip to content

Conversation

@jacob-pascual
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 4, 2018

Coverage Status

Coverage increased (+0.01%) to 61.866% when pulling ca4b134 on jacobgreenleaf-patch-1 into 59e39cf on master.

CHANGELOG.md Outdated
### Added
- Application configuration (e.g. `config/base.json`) can now be specified in YAML in addition to JSON (). Zanzibar will look for the `yaml` file first, and fall back to `json` file if it does not exist. JSON static configuration support may be removed in future major releases.
- Module configuration (`services/<name>/service-config.json`) can now be specified as YAML ina ddition to JSON (#468).
- Panics in endpoints are now caught (#458). HTTP endpoints return `502` status code with a body `"Unexpected workflow panic, recovered at endpoint."`. TChannel endpoints will (@jacobgreenleaf: ?).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfinished sentence?

CHANGELOG.md Outdated
- **GetContextScopeExtractors**:Added [`GetContextScopeExtractors`](https://godoc.org/github.com/uber/zanzibar/runtime#GetContextScopeExtractors) interface. For migration, define var AppOptions *zanzibar.Options at PackageRoot and implement interface accordingly.
### Deprecated
- JSON static configuration support is now deprecated.
- `JSONFileRaw` and `JSONFileName` fields of [`ModuleInstance`](https://godoc.org/github.com/uber/zanzibar/codegen#ModuleInstance) now deprecated. When YAML configuration is used, `JSONFileRaw` and `JSONFileName` will be zero-valued.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are now deprecated.

@jacob-pascual jacob-pascual merged commit 3974949 into master Oct 8, 2018
@jacob-pascual jacob-pascual deleted the jacobgreenleaf-patch-1 branch October 8, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants