Add url pattern field

[Ryanfsdf]

A middleware needs access to rawURLPattern for logging purposes. Included this field in ServerHTTPRequest

[Ryanfsdf]

Hi @ChuntaoLu @jacobgreenleaf Could I get this and #559 reviewed? A middleware in edge gateway needs access to these fields for logging purposes. Thank you!

[coveralls]

Coverage increased (+3.8%) to 68.42% when pulling 7691df9 on add-url-pattern-field into b341b6c on master.

[ChuntaoLu]

I understand this test is for the specific url, but it is wired to say "this endpoint handles requests with the url that has the specific query values". Usually we only specify the url path, i.e., without the ? part.

[Ryanfsdf]

This was a mistake on my end. In its place is supposed to be just "/foo"

[ChuntaoLu]

This means an endpoint is always associated with a url, what would be the answers to following questions:

• what is the expectation for below?

router.Handle("GET", "/foo",  http.HandlerFunc(zanzibar.NewRouterEndpoint(a, b, "foo", "foo", "/bar", c)))

it uses an endpoint that is for /bar to handle /foo, seems error-prone and shouldn't be allowed?

• previously I can use the same handler to handle different urls, now I will have to create one endpoint per url?

Overall, I don't think it is a good idea to couple the association between an url and an endpoint with the endpoint itself.

[Ryanfsdf]

I understand your points for concern.

However, I need a way to uniquely identify an endpoint in a form canonical to both edge gateway and rtapi. The two choices are the url or thrift method, since EndpointName and HandlerName are specific to edge gateway and not to rtapi. However, passing even the thrift method into NewRouterEndpoint would be coupling the association between a url and an endpoint with the endpoint itself because the thrift method is mapped 1-to-1 with the url.

I'll try to figure out a different way to uniquely identify an endpoint, but please let me know if you have any suggestions.

Again, thanks a lot for the review!

[jacob-pascual]

A middleware needs access to rawURLPattern for logging purposes. Included this field in ServerHTTPRequest

Can you describe the purpose more? Would it be sufficient to log the URL path part when you receive a request rather than the pattern that the path matched?

[Ryanfsdf]

A middleware needs access to rawURLPattern for logging purposes. Included this field in ServerHTTPRequest

Can you describe the purpose more? Would it be sufficient to log the URL path part when you receive a request rather than the pattern that the path matched?

URL path part is sufficient. However, I need the path part before the path parameters have been filled in. For example, /test/:uuid/example vs /test/12345/example. ServerHTTPRequest.Url contains /test/12345/example but not /test/:uuid/example, which is what I need.

In terms of purpose, I need a way to uniquely identify an endpoint in a form which is canonical to both edge gateway and rtapi, and the url seemed like a good candidate.

[jacob-pascual]

A middleware needs access to rawURLPattern for logging purposes. Included this field in ServerHTTPRequest

Can you describe the purpose more? Would it be sufficient to log the URL path part when you receive a request rather than the pattern that the path matched?

URL path part is sufficient. However, I need the path part before the path parameters have been filled in. For example, /test/:uuid/example vs /test/12345/example. ServerHTTPRequest.Url contains /test/12345/example but not /test/:uuid/example, which is what I need.

In terms of purpose, I need a way to uniquely identify an endpoint in a form which is canonical to both edge gateway and rtapi, and the url seemed like a good candidate.

Shouldn't the URL after the path parameters are filled in also be sufficient? After all when the router receives the URL it will be with the path parameters filled in. The router will only match the URL with one pattern. Would like to hear more about the use case.