Skip to content

Run postGenHook per build instead of per instance #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChuntaoLu merged 1 commit into from
Jul 18, 2019
Merged

Run postGenHook per build instead of per instance #612

ChuntaoLu merged 1 commit into from
Jul 18, 2019

Conversation

@ChuntaoLu
Copy link
Contributor

@ChuntaoLu ChuntaoLu commented Jul 18, 2019

This PR corrects the postGenHook invocation to be per build instead of per module instance.

rpatali
rpatali reviewed Jul 18, 2019
View reviewed changes
@coveralls
Copy link

coveralls commented Jul 18, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 67.605% when pulling 17340fe on lu.hook into 073a751 on master.

@ChuntaoLu ChuntaoLu merged commit 8c774c1 into master Jul 18, 2019
@ChuntaoLu ChuntaoLu deleted the lu.hook branch July 18, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rpatali rpatali rpatali approved these changes

@jacob-pascual jacob-pascual Awaiting requested review from jacob-pascual

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChuntaoLu @coveralls @rpatali