feat(mapIds): add option for cloud map styles #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreashelms
reviewed
Jul 7, 2020
README.md
Outdated
| mapContainer={mapContainer} | ||
| options={mapOptions} | ||
| libraries={['places']} | ||
| mapIds={['d85da84f141b8b84']} |
Contributor
There was a problem hiding this comment.
Where does this id come from?
Contributor
Author
There was a problem hiding this comment.
This is a random test id that I created. There will be no actual mapstyle with this id. I just wanted to include an authentic id to show what an id looks like.
You have to create your ids in the cloud console.
Contributor
There was a problem hiding this comment.
I would rather use your-mapstyle-id or something, otherwise it's not clear whether this id is valid or not. But only as suggestion, not blocking here.
andreashelms
previously approved these changes
Jul 7, 2020
andreashelms
reviewed
Jul 7, 2020
| mapContainer={mapContainer} | ||
| options={mapOptions} | ||
| libraries={['places']} | ||
| mapIds={['<your-mapstyle-id>']} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option for cloud map style from the linked GCP project
https://developers.google.com/maps/documentation/javascript/cloud-based-map-styling#maps_map_id_style-html