Skip to content

Conversation

@meziantou
Copy link
Contributor

@meziantou meziantou commented Nov 22, 2021

  • Add a new dependency: Microsoft.Bcl.AsyncInterfaces
  • Change the target framework from net45 to net461 as this is the minimum version supported by Microsoft.Bcl.AsyncInterfaces
  • Add GitLabCollectionResponse<T>
  • Add a unit test to ensure the new async methods follow best practices

fix #45

@jontdelorme
Copy link
Contributor

I like the general approach. It makes it easy to add an async implementation to an interface

@meziantou meziantou marked this pull request as ready for review November 23, 2021 01:10
@meziantou meziantou requested a review from a team as a code owner November 23, 2021 01:10
@meziantou meziantou requested review from Toa741 and jairbubbles and removed request for a team November 23, 2021 01:10
meziantou and others added 2 commits November 23, 2021 12:18
Co-authored-by: Louis Zanella <louis.zanella@ubisoft.com>
Co-authored-by: Louis Zanella <louis.zanella@ubisoft.com>
@Toa741 Toa741 merged commit 638afce into main Nov 24, 2021
@Toa741 Toa741 deleted the async branch November 24, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants