Minor fixes to SamplesDef.json and related Powershell scripts: #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While trying to test a Sharpmake sample with the provided Powershell scripts RunSample.ps1 and RunSharpmake.ps1 I ran into two issues that this change fixes: - SamplesDef.json was malformed and had a trailing comma that caused RunSample.ps1 to fail parsing it correctly. - RunSharpmake.ps1 didn't correctly detect I was running on Windows and error-ed attempting to run `chmod`.
Collaborator
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to test a Sharpmake sample with the provided Powershell scripts
RunSample.ps1andRunSharpmake.ps1on Windows I ran into two issues that this change fixes:SamplesDef.jsonwas malformed and had a trailing comma that causedRunSample.ps1to fail parsing it correctly.RunSharpmake.ps1didn't correctly detect I was running on Windows and error-ed attempting to runchmod.