Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/src/base_spin_box.dart
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ abstract class BaseSpinBox extends StatefulWidget {
double get min;
double get max;
double get step;
double get pageStep;
double get value;
int get decimals;
int get digits;
Expand Down Expand Up @@ -66,8 +67,10 @@ mixin SpinBoxMixin<T extends BaseSpinBox> on State<T> {
return {
// ### TODO: use SingleActivator fixed in Flutter 2.10+
// https://github.com/flutter/flutter/issues/92717
LogicalKeySet(LogicalKeyboardKey.arrowUp): _increaseValue,
LogicalKeySet(LogicalKeyboardKey.arrowDown): _decreaseValue,
LogicalKeySet(LogicalKeyboardKey.arrowUp): _stepUp,
LogicalKeySet(LogicalKeyboardKey.arrowDown): _stepDown,
LogicalKeySet(LogicalKeyboardKey.pageUp): _pageStepUp,
LogicalKeySet(LogicalKeyboardKey.pageDown): _pageStepDown,
};
}

Expand All @@ -92,8 +95,11 @@ mixin SpinBoxMixin<T extends BaseSpinBox> on State<T> {
super.dispose();
}

void _increaseValue() => setValue(value + widget.step);
void _decreaseValue() => setValue(value - widget.step);
void _stepUp() => setValue(value + widget.step);
void _stepDown() => setValue(value - widget.step);

void _pageStepUp() => setValue(value + widget.pageStep);
void _pageStepDown() => setValue(value - widget.pageStep);

void _updateValue() {
final v = _parseValue(_controller.text);
Expand Down
7 changes: 7 additions & 0 deletions lib/src/cupertino/spin_box.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class CupertinoSpinBox extends BaseSpinBox {
this.min = 0,
this.max = 100,
this.step = 1,
this.pageStep = 10,
this.value = 0,
this.interval = const Duration(milliseconds: 100),
this.acceleration,
Expand Down Expand Up @@ -119,6 +120,12 @@ class CupertinoSpinBox extends BaseSpinBox {
@override
final double step;

/// The page step size for incrementing and decrementing the value.
///
/// Defaults to `10.0`.
@override
final double pageStep;

/// The current value.
///
/// Defaults to `0.0`.
Expand Down
7 changes: 7 additions & 0 deletions lib/src/material/spin_box.dart
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class SpinBox extends BaseSpinBox {
this.min = 0,
this.max = 100,
this.step = 1,
this.pageStep = 10,
this.value = 0,
this.interval = const Duration(milliseconds: 100),
this.acceleration,
Expand Down Expand Up @@ -117,6 +118,12 @@ class SpinBox extends BaseSpinBox {
@override
final double step;

/// The page step size for incrementing and decrementing the value.
///
/// Defaults to `10.0`.
@override
final double pageStep;

/// The current value.
///
/// Defaults to `0.0`.
Expand Down
36 changes: 36 additions & 0 deletions test/test_spinbox.dart
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,42 @@ void testInput<S>(TestBuilder builder) {
expect(find.editableText, hasText('0'));
});

testWidgets('page step', (tester) async {
await tester.pumpWidget(builder());
expect(find.editableText, hasFocus);
await tester.showKeyboard(find.byType(S));

await tester.sendKeyEvent(LogicalKeyboardKey.pageDown);
await tester.idle();
expect(tester.state(find.byType(S)), hasValue(0));
expect(find.editableText, hasText('0'));

await tester.sendKeyEvent(LogicalKeyboardKey.pageUp);
await tester.idle();
expect(tester.state(find.byType(S)), hasValue(10));
expect(find.editableText, hasText('10'));

await tester.sendKeyEvent(LogicalKeyboardKey.pageUp);
await tester.idle();
expect(tester.state(find.byType(S)), hasValue(20));
expect(find.editableText, hasText('20'));

await tester.sendKeyEvent(LogicalKeyboardKey.arrowDown);
await tester.idle();
expect(tester.state(find.byType(S)), hasValue(19));
expect(find.editableText, hasText('19'));

await tester.sendKeyEvent(LogicalKeyboardKey.pageDown);
await tester.idle();
expect(tester.state(find.byType(S)), hasValue(9));
expect(find.editableText, hasText('9'));

await tester.sendKeyEvent(LogicalKeyboardKey.pageDown);
await tester.idle();
expect(tester.state(find.byType(S)), hasValue(0));
expect(find.editableText, hasText('0'));
});

testWidgets('text', (tester) async {
await tester.pumpWidget(builder());
expect(find.editableText, hasFocus);
Expand Down