Skip to content

Fix active icon color #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Fix active icon color #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bc1502
Fix active icon color
jpnurmi Feb 26, 2023
6ffbddc
Merge branch 'main' into active-icon-color
jpnurmi Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions lib/src/material/spin_box.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,21 +277,9 @@ class SpinBox extends BaseSpinBox {
}

class _SpinBoxState extends State<SpinBox> with SpinBoxMixin {
Color _activeColor(ThemeData theme) {
if (hasFocus) {
switch (theme.brightness) {
case Brightness.dark:
return theme.colorScheme.secondary;
case Brightness.light:
return theme.primaryColor;
}
}
return theme.hintColor;
}

Color? _iconColor(ThemeData theme, String? errorText) {
if (!widget.enabled) return theme.disabledColor;
if (hasFocus && errorText == null) return _activeColor(theme);
if (hasFocus && errorText == null) return theme.colorScheme.primary;

switch (theme.brightness) {
case Brightness.dark:
Expand Down