Skip to content

Early support for GNOME 50-pre-alpha #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leleat merged 2 commits into from
Dec 21, 2025
Merged

Early support for GNOME 50-pre-alpha #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
230559b
Avoid calling Meta.is_wayland_compositor() if it doesn't exist
vanvugt Dec 18, 2025
446d59f
metadata.json: Declare support for GNOME 50
vanvugt Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tiling-assistant@leleat-on-github/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"name": "Tiling Assistant",
"shell-version": [
"48",
"49"
"49",
"50"
],
"url": "https://github.com/Leleat/Tiling-Assistant",
"uuid": "tiling-assistant@leleat-on-github",
Expand Down
7 changes: 7 additions & 0 deletions tiling-assistant@leleat-on-github/src/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
* *and* prefs files
*/

import { Meta } from './dependencies/gi.js';

/**
* A Singleton providing access to the settings.
*/
Expand Down Expand Up @@ -321,3 +323,8 @@ var LayoutItem = class LayoutItem {
this.loopType = null;
}
};

export function is_wayland_compositor() {
return Meta.is_wayland_compositor === undefined ||
Meta.is_wayland_compositor();
}
4 changes: 2 additions & 2 deletions tiling-assistant@leleat-on-github/src/extension/moveHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Clutter, GLib, GObject, Gio, Meta, Mtk } from '../dependencies/gi.js';
import { Main, WindowManager } from '../dependencies/shell.js';
import { WINDOW_ANIMATION_TIME } from '../dependencies/unexported/windowManager.js';

import { Orientation, MoveModes, Settings } from '../common.js';
import { Orientation, MoveModes, Settings, is_wayland_compositor } from '../common.js';
import { Rect, Util } from './utility.js';
import { TilingWindowManager as Twm } from './tilingWindowManager.js';

Expand Down Expand Up @@ -319,7 +319,7 @@ export default class TilingMoveHandler {
const altL = Clutter.ModifierType.MOD1_MASK;
const altGr = Clutter.ModifierType.MOD5_MASK;
const meta = Clutter.ModifierType.MOD4_MASK;
const rmb = Meta.is_wayland_compositor()
const rmb = is_wayland_compositor()
? Clutter.ModifierType.BUTTON2_MASK
: Clutter.ModifierType.BUTTON3_MASK;
const pressed = [ // idxs come from settings
Expand Down
6 changes: 3 additions & 3 deletions tiling-assistant@leleat-on-github/src/extension/tilingPopup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Clutter, GObject, Meta, St } from '../dependencies/gi.js';
import { Clutter, GObject, St } from '../dependencies/gi.js';
import { Main } from '../dependencies/shell.js';
import * as SwitcherPopup from '../dependencies/unexported/switcherPopup.js';

import { Direction, Orientation } from '../common.js';
import { Direction, Orientation, is_wayland_compositor } from '../common.js';
import { Util } from './utility.js';
import { TilingWindowManager as Twm } from './tilingWindowManager.js';
import * as AltTab from './altTab.js';
Expand Down Expand Up @@ -52,7 +52,7 @@ export const TilingSwitcherPopup = GObject.registerClass({

// Destroy popup when touching outside of popup
this.connect('touch-event', () => {
if (Meta.is_wayland_compositor())
Copy link
Copy Markdown
Collaborator

@3v1n0 3v1n0 Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just use Meta.is_wayland_compositor?.() ?? true everywhere :)

Copy link
Copy Markdown
Contributor Author

@vanvugt vanvugt Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds true but I don't use Javascript often enough for that syntax to feel as natural.

if (is_wayland_compositor())
this.fadeAndDestroy();

return Clutter.EVENT_PROPAGATE;
Expand Down