Small bugfixes to Autotools#4
Conversation
| if test x"$MOC4" = xmoc; then | ||
| if test x"$(readlink $(which $MOC4))" = xqtchooser; then | ||
| MOC4="$MOC4 --qt=qt4" | ||
| MOC4="$MOC4 --qt=4" |
There was a problem hiding this comment.
Is this not working somewhere? I get the following (which suggests 4 and 5 are the recommended value to be passed).
$ qtchooser -l
4
5
default
qt4-x86_64-linux-gnu
qt4
qt5-x86_64-linux-gnu
qt5
There was a problem hiding this comment.
This was a downstream patch we carried in Fedora / EPEL since some long time. The patch actually changes to an invocation with the recommend values, as you described.
| AM_INIT_AUTOMAKE([1.11 no-dist-gzip dist-xz foreign]) | ||
| AM_SILENT_RULES(yes) | ||
| LT_INIT | ||
| AC_PROG_CC_STDC |
There was a problem hiding this comment.
What is occurring with this not set?
There was a problem hiding this comment.
Without that being set building lightdm v1.25.1 fails to build on RHEL7 / CentOS7, because the changes in code require the compiler to be run in -std=c99 mode.
| @@ -1,3 +1,4 @@ | |||
| ACLOCAL_AMFLAGS = -I m4 | |||
There was a problem hiding this comment.
What is occurring with this not set?
There was a problem hiding this comment.
This fixes libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am..
besser82
force-pushed
the
bugfix/qtchooser
branch
2 times, most recently
from
7347d4b to
4520eae
Compare
besser82
force-pushed
the
bugfix/qtchooser
branch
from
4520eae to
cdda416
Compare
2 participants
No description provided.