Include Reg into microk8s

[etheleon]

As suggested in this thread, reg will be a good addition to enable users to easily interact with local registry

[etheleon]

@ktsakalozos , the tests are failing any idea why?

[ktsakalozos]

I do not think you are doing anything with argz so lets simplify the code by removing these two lines.

[etheleon]

Alright!

[ktsakalozos]

I think a single message should be enough. :)

[etheleon]

Alright!

[ktsakalozos]

MicroK8s ships for amd64 adn arm64, so we should use the $SNAP_ARCH to get the right binary from the releases. Something like this should work: https://github.com/genuinetools/reg/releases/download/${REG_VERSION}/reg-linux-${SNAP_ARCH}.

[etheleon]

Alright!

[ktsakalozos]

@etheleon thank you for this PR. I left a few comments. It would be great if you could somehow add a test for this addon. Here is how to do that:

• In https://github.com/ubuntu/microk8s/blob/master/tests/test-addons.py#L65 and https://github.com/ubuntu/microk8s/blob/master/tests/test-upgrade.py#L92 enable reg along with the registry.
• In https://github.com/ubuntu/microk8s/blob/master/tests/validators.py#L163 use the reg binary to do any operation on the private registry. An ls should return the my-busybox image, right?

If you follow the instruction and build MicroK8s from source https://github.com/ubuntu/microk8s#building-from-source you should see that you do not have a microk8s.reg command in your path. The reason is you are missing an entry into snapcraft.yaml like this one: https://github.com/ubuntu/microk8s/blob/master/snapcraft.yaml#L66 and the corresponding wrapper script like this one: https://github.com/ubuntu/microk8s/blob/master/microk8s-resources/wrappers/microk8s-linkerd.wrapper

It would have been better if the fist time you try the microk8s.req command the wrapper would download the binary then. This way you would not need the microk8s.enable reg step. What do you think?

[etheleon]

@ktsakalozos Thanks for the detailed write up on writing the test! Let me get started on it! :)

[etheleon]

Hi @ktsakalozos, made the following changes:

• snapcraft: added reg as app

• validator: include validator for reg

  • tags busybox
  • push to local registry
  • assets presence of image
  • deletes tag

• microk8s.reg wrapper: installs reg if binary not found. Based on your suggestion here. Yes i agree!

It would have been better if the fist time you try the microk8s.req command the wrapper would download the binary then. This way you would not need the microk8s.enable reg step. What do you think?

• microk8s.enable reg: installs reg (might be duplicate)

Should we keep this?

[ktsakalozos]

@etheleon are you able to see this: https://travis-ci.org/ubuntu/microk8s/builds/534665856?utm_source=github_status&utm_medium=notification ?

I believe you are missing an import.

       validate_reg()
      NameError: global name 'validate_reg' is not defined

[ktsakalozos]

@etheleon now we have:

>       output = (subprocess
                  .run(['reg', 'ls', '-f', 'localhost:32000'], stdout=subprocess.PIPE)
                  .stdout
                  .decode('utf-8')
                  .split("\n"))
E       AttributeError: 'module' object has no attribute 'run'

I should document how to run the tests locally, (they are run with pytest).

[ktsakalozos]

Can you please add a timeout_insec=30 when enabling the add-on. If we do not set a timeout enabling tries for too long and tests on travis timeout.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ktsakalozos]

Closing this PR due to inactivity.