Skip to content

Conversation

@Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Apr 12, 2023

Before:

Capture d’écran du 2023-04-12 14-12-31
Capture d’écran du 2023-04-12 14-13-09
Capture d’écran du 2023-04-12 14-13-23

After:

Capture d’écran du 2023-04-12 14-02-43
Capture d’écran du 2023-04-12 14-04-32
Capture d’écran du 2023-04-12 14-03-43

Closes #3887, closes #3881

Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Good job!

(( Offtopic: would still safe you a bunch of time, if this could all be upstreamed one day ))
(( Offtopic: the new font looks very nice ))

@Feichtmeier
Copy link
Member

I think you need to separate the closes issuexyz by new lines and add a closes in front of each issue tag (I could be wrong)

Copy link
Member

@Muqtxdir Muqtxdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, better now

@Jupi007
Copy link
Member Author

Jupi007 commented Apr 12, 2023

I think you need to separate the closes issuexyz by new lines and add a closes in front of each issue tag (I could be wrong)

Thanks you was right, I didn't noticed that the second linked issue didn't worked :)

(( Offtopic: would still safe you a bunch of time, if this could all be upstreamed one day ))

I agree. I will try to ask upstream, if I can find the time to work on (not for now so 😅).
((I think @Muqtxdir reported that they already think about provide a real light theme))

@Jupi007 Jupi007 merged commit 8a3752e into master Apr 12, 2023
@Jupi007 Jupi007 deleted the GnomeShell_light_theme_fixes branch April 12, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gs: context menu unselectable entries are invisible in light Looking glass hints not readable using light theme

4 participants