Folders: Increase pictogram contrasts and adjust some inconsistencies

[3v1n0]

See commits for details, but ensuring that the folders do not look as "selected", due to the too light lighten overlay, and use darker pictograms to ensure they have enough contrast.

Maybe we could reduce the pictograms darken overlays opacity for bigger icons, but I preferred to stay consistent for now.

EDIT: Github diff seems broken, so check changes locally, some are

FYI @ochi12

[Muqtxdir]

Can we change the orange shade to the pre-20.04 era shade, this orange looks more leaning towards red side than to orange 🤔

[ochi12]

Looking at my phone I think it's too contrasty, can we dial it in between the old one and your current one? And match the dark part of the folder with the stamp color to sell the effect of it as a deep stamp.

I actually went with the lighter part because as @Muqtxdir said it approaches a red tone. But if it is too bright then your changes are a very well done, but I think we need to dial it down a little bit. Maybe for the dark part of the folder (old - new)*0.5 and for the stamps, (old - new)*0.65, and fort he lighten effect, (old-new)*0.5

[3v1n0]

Well for the orange case we could go with a special case, I'm fine with that, while for the other colors I'd go with auto-generation.

However, we could reduce the contrast to me as well, this was to reach the "expected" (for pictograms) 3.0 ratio, but we could also lower it a bit from my POV, especially in the big icons.

@ochi12 if you have time to play with the opacity levels in the svg, feel free (but use mine as base)... That's the only thing that manages the colors here at this point.

Maybe even just using:

diff --git a/common/accent-colors.scss.in b/common/accent-colors.scss.in
index 269dd515b..87f7ebc49 100644
--- a/common/accent-colors.scss.in
+++ b/common/accent-colors.scss.in
@@ -67,6 +67,6 @@ $accent-color-dark-bg: if($yaru_is_dark_variant, $accent_color,
         $target: $contrast_target));
 
 $yaru_accent_color_on_accent_color: optimize-contrast($accent_color,
-    $accent_color, $target: 3.5);
+    $accent_color, $target: 3.0);
 
 @import '@yaru_theme_entry_point@'

And then just regenerate with ninja -C _build icon-render-folders

[3v1n0]

Just reducing the contrast target we'd get (compared to the one in this PR):

Now... this is fine for the big icons, maybe for the small ones it's still better to get higher contrast, wdyt?

[ochi12]

Just reducing the contrast target we'd get (compared to the one in this PR):

Now... this is fine for the big icons, maybe for the small ones it's still better to get higher contrast, wdyt?

Yup small icons are considerations. I will try to play around with the values to see what best fits ligth and dark system themes

[ochi12]

Seeing omg ubuntu's comment section many like it but most have mixed opinion. The downside is really the pictograms lack of contrast with is clearly my fault. This PR still targets 26.04 right?

[3v1n0]

This PR still targets 26.04 right?

Yes these are still bugs and not changing the main look

[3v1n0]

I had not much time to play more with values here, but I think it's worth a try and we can still adjust the lightining/darkening effects later.

[Feichtmeier]

let's hope people really meant "brightness" and not "saturation"? :) Because too much color/saturation sometimes can feel too jarring

[ochi12]

let's hope people really meant "brightness" and not "saturation"? :) Because too much color/saturation sometimes can feel too jarring

We can still make more improvements. But a lot ask for contrast so we give them contrast