Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ConfigFragments.scala into multiple files by usage #1061

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Dec 15, 2021

The ConfigFragments.scala file has grown too large as the dumping ground of assorted integration-level fragments.
This PR splits that file into several XFragments.scala files, and moves them to the config/fragments subdirectory.

Some of the files are currently quite empty (Ex: SubsystemFragments.scala), but I think that is ok.

This also removes firrtl-intepreter and treadle from the commit-on-master check, as those projects are no longer tracked by submodule.

Type of change: other enhancement

Impact: software change

Release Notes

  • Split ConfigFragments.scala into several Fragment files

@jerryz123
Copy link
Contributor Author

Barstools is not on master, as expected

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending small nits.

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 merged commit 8826486 into dev Dec 17, 2021
@jerryz123 jerryz123 deleted the split_fragments branch October 1, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants