Skip to content

fix: switch unicode-utils package around#360

Merged
luxass merged 3 commits intomainfrom
switch-unicode-utils
Oct 25, 2025
Merged

fix: switch unicode-utils package around#360
luxass merged 3 commits intomainfrom
switch-unicode-utils

Conversation

@luxass
Copy link
Member

@luxass luxass commented Oct 25, 2025

🔗 Linked issue

📚 Description

Summary by CodeRabbit

  • Chores
    • Updated and consolidated internal utility dependencies across multiple packages to enhance version consistency and maintainability.

…to `@luxass/unicode-utils-old`

* Changed imports in multiple files to use `@luxass/unicode-utils-old` instead of `@luxass/unicode-utils`.
* Updated `package.json` and `pnpm-lock.yaml` to reflect the new dependency.
* Ensured compatibility with existing code by maintaining the same version.
* Updated all instances of `@luxass/unicode-utils-new` to `@luxass/unicode-utils` across multiple packages.
* Ensured consistency in dependency management and resolved potential issues related to outdated references.
…ass/unicode-utils`

* Replaced `@luxass/unicode-utils-old` with `@luxass/unicode-utils` in `package.json` and related files.
* Updated import statements to reflect the new dependency.
* Ensured compatibility with the latest version of the Unicode utilities.
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2025

⚠️ No Changeset found

Latest commit: b5d2405

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This PR consolidates unicode utility dependencies across the codebase. Most packages migrate from the "@luxass/unicode-utils-new" alias to the primary "@luxass/unicode-utils" alias (version 0.12.0-beta.11), while packages/schema-gen switches to "@luxass/unicode-utils-old" (version 0.11.0). The pnpm workspace catalog is updated to reflect these alias changes.

Changes

Cohort / File(s) Summary
API Package Migration
apps/api/package.json, apps/api/src/routes/v1_versions/routes.ts, apps/api/test/routes/v1_versions.test.ts
Replaced "@luxass/unicode-utils-new" imports with "@luxass/unicode-utils" in package dependency and all source/test imports.
CLI Package Updates
packages/cli/src/cmd/store/_shared.ts, packages/cli/test/cmd/store/init.test.ts
Added type casting for version field in multiselect options; removed inline TypeScript error suppression comments in mock setups.
Schema Gen Package Migration
packages/schema-gen/package.json, packages/schema-gen/src/(fields.ts, index.ts), packages/schema-gen/test/fields.test.ts
Migrated from "@luxass/unicode-utils" to "@luxass/unicode-utils-old" across package dependency and all RawDataFile type imports.
Shared & Store V2 Dependencies
packages/shared/package.json, packages/ucd-store-v2/package.json
Updated "@luxass/unicode-utils-new" to "@luxass/unicode-utils" in dependency declarations.
UCD Store Refactoring
packages/ucd-store/package.json, packages/ucd-store/src/internal/mirror.ts, packages/ucd-store/test/(core/init.test.ts, file-operations/\\*.test.ts, maintenance/\\*.test.ts)
Consolidated dependency and all imports of UNICODE_VERSION_METADATA and resolveUCDVersion from "@luxass/unicode-utils-new" to "@luxass/unicode-utils".
VSCode Extension Updates
vscode/package.json, vscode/src/(commands/open-entry.ts, composables/useUCDExplorer.ts, lib/files.ts)
Migrated devDependency and all imports of hasUCDFolderPath and UNICODE_VERSION_METADATA from "@luxass/unicode-utils-new" to "@luxass/unicode-utils".
Workspace Configuration
pnpm-workspace.yaml
Updated prod catalog aliases: remapped "@luxass/unicode-utils" (0.11.0) → "@luxass/unicode-utils-old" and "@luxass/unicode-utils-new" (0.12.0-beta.11) → "@luxass/unicode-utils".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Homogeneous pattern: Majority of changes follow a consistent import/dependency replacement pattern across multiple cohorts
  • Volume consideration: Despite ~25 affected files, the repetitive nature reduces per-file review complexity
  • Key area to verify:
    • Ensure the pnpm workspace catalog changes correctly resolve the two unicode-utils versions and that API compatibility is maintained between 0.11.0 and 0.12.0-beta.11
    • Confirm schema-gen's use of the "-old" alias is intentional and does not cause breaking changes

Possibly related PRs

Poem

🐰 From "new" to steady, we hop along,
Old and fresh versions, both strong,
Dependencies dance in the catalog's light,
Unified imports, our codebase's delight!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch switch-unicode-utils

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f2f074 and b5d2405.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (27)
  • apps/api/package.json (1 hunks)
  • apps/api/src/routes/v1_versions/routes.ts (1 hunks)
  • apps/api/test/routes/v1_versions.test.ts (10 hunks)
  • packages/cli/src/cmd/store/_shared.ts (1 hunks)
  • packages/cli/test/cmd/store/init.test.ts (0 hunks)
  • packages/schema-gen/package.json (1 hunks)
  • packages/schema-gen/src/fields.ts (1 hunks)
  • packages/schema-gen/src/index.ts (1 hunks)
  • packages/schema-gen/test/fields.test.ts (1 hunks)
  • packages/shared/package.json (1 hunks)
  • packages/ucd-store-v2/package.json (1 hunks)
  • packages/ucd-store/package.json (1 hunks)
  • packages/ucd-store/src/internal/mirror.ts (1 hunks)
  • packages/ucd-store/test/core/init.test.ts (1 hunks)
  • packages/ucd-store/test/file-operations/capability-requirements.test.ts (1 hunks)
  • packages/ucd-store/test/file-operations/file-paths.test.ts (1 hunks)
  • packages/ucd-store/test/file-operations/file-tree.test.ts (1 hunks)
  • packages/ucd-store/test/file-operations/get-file.test.ts (1 hunks)
  • packages/ucd-store/test/maintenance/analyze.test.ts (1 hunks)
  • packages/ucd-store/test/maintenance/clean.test.ts (1 hunks)
  • packages/ucd-store/test/maintenance/mirror.test.ts (1 hunks)
  • packages/ucd-store/test/maintenance/repair.test.ts (1 hunks)
  • pnpm-workspace.yaml (1 hunks)
  • vscode/package.json (1 hunks)
  • vscode/src/commands/open-entry.ts (1 hunks)
  • vscode/src/composables/useUCDExplorer.ts (1 hunks)
  • vscode/src/lib/files.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added pkg: cli Changes related to the CLI package. pkg: schema-gen Changes related to the Schema Gen package. pkg: ucd-store Changes related to the UCD Store package. apps: api Changes related to the API. pkg: shared Changes related to the Shared package. labels Oct 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2025

🌏 Preview Deployments

Application Status Preview URL
API ⏭️ Skipped N/A
Website ⏭️ Skipped N/A
Documentation ⏭️ Skipped N/A

Built from commit: b5d2405b9993896b207275e4b95b15f75dc872f3


🤖 This comment will be updated automatically when you push new commits to this PR.

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@luxass luxass marked this pull request as ready for review October 25, 2025 10:14
Copilot AI review requested due to automatic review settings October 25, 2025 10:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates package references from @luxass/unicode-utils-new to @luxass/unicode-utils throughout the codebase, switching to use the newer beta version (0.12.0-beta.11) as the primary package. The old stable version (0.11.0) is retained as @luxass/unicode-utils-old for packages that still require it.

Key Changes

  • Updated import statements across the codebase to use @luxass/unicode-utils instead of @luxass/unicode-utils-new
  • Modified workspace catalog configuration to alias the old version and promote the beta version as the primary package
  • Updated schema-gen package to use the old version aliased as @luxass/unicode-utils-old

Reviewed Changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-workspace.yaml Reorganized catalog entries to alias old version and promote beta as primary
vscode/package.json Updated dependency reference to new package name
packages/ucd-store/package.json Updated dependency reference to new package name
packages/ucd-store-v2/package.json Updated dependency reference to new package name
packages/shared/package.json Updated dependency reference to new package name
packages/schema-gen/package.json Updated to use old version alias
apps/api/package.json Updated dependency reference to new package name
vscode/src/lib/files.ts Updated import statement
vscode/src/composables/useUCDExplorer.ts Updated import statement
vscode/src/commands/open-entry.ts Updated import statement
packages/ucd-store/src/internal/mirror.ts Updated import statement
packages/schema-gen/src/index.ts Updated import to use old version alias
packages/schema-gen/src/fields.ts Updated import to use old version alias
packages/schema-gen/test/fields.test.ts Updated import to use old version alias
apps/api/src/routes/v1_versions/routes.ts Updated import statement
apps/api/test/routes/v1_versions.test.ts Updated mock and import statements
packages/cli/src/cmd/store/_shared.ts Added type assertion for version values
packages/cli/test/cmd/store/init.test.ts Removed ts-expect-error comments
13 test files in packages/ucd-store/test/ Updated import statements
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luxass luxass merged commit 88d6109 into main Oct 25, 2025
25 of 26 checks passed
@luxass luxass deleted the switch-unicode-utils branch October 25, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apps: api Changes related to the API. pkg: cli Changes related to the CLI package. pkg: schema-gen Changes related to the Schema Gen package. pkg: shared Changes related to the Shared package. pkg: ucd-store Changes related to the UCD Store package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant