chore: update turbo.json configurations across multiple packages#516
chore: update turbo.json configurations across multiple packages#516
turbo.json configurations across multiple packages#516Conversation
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR adds Turborepo configuration files (turbo.json) to multiple workspace packages across apps, packages/pipelines, and tooling directories. Additionally, it modifies the root turbo.json to update build dependencies and adds environment file tracking, while adjusting specific task outputs in apps/api and apps/store to include wrangler-types.d.ts generation artifacts. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🌏 Preview Deployments
Built from commit: 🤖 This comment will be updated automatically when you push new commits to this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chore(vitest-pool-workers): update to version 0.12.13
There was a problem hiding this comment.
Pull request overview
This PR standardizes and improves turbo.json configurations across the monorepo. It adds new package-specific turbo.json files for previously unconfigured packages, updates global environment tracking, improves build task dependencies, and updates several development dependencies.
Changes:
- Adds
.envand.env.*to global dependencies for better cache invalidation on environment changes - Removes unnecessary global
@ucdjs/api#build:openapibuild dependency, delegating to package-specific dependencies where needed - Creates turbo.json files for 13 packages (apps/web, apps/docs, pipeline packages, and tooling packages) to enable proper task caching
- Updates output path specification in apps/api to use
$TURBO_ROOT$variable for clarity - Adds
wrangler-types.d.tsto typecheck outputs for Cloudflare Workers packages - Bumps
@ucdjs/release-scriptsto 0.1.0-beta.57 and@cloudflare/vitest-pool-workersto ccaf85f
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| turbo.json | Adds .env tracking to globalDependencies and removes unnecessary @ucdjs/api#build:openapi from build task |
| apps/api/turbo.json | Updates OpenAPI output path to use |
| apps/store/turbo.json | Adds wrangler-types.d.ts to typecheck outputs |
| apps/web/turbo.json | New turbo.json with build, dev, lint, and typecheck tasks |
| apps/docs/turbo.json | New turbo.json with build, dev, and lint tasks (missing typecheck) |
| packages/worker-utils/turbo.json | Adds generate:types task configuration |
| packages/pipelines/pipeline-*/turbo.json | New turbo.json files for 6 pipeline packages with consistent task configurations |
| tooling/*/turbo.json | New turbo.json files for 4 tooling packages with appropriate task configurations |
| pnpm-workspace.yaml | Updates @ucdjs/release-scripts and @cloudflare/vitest-pool-workers versions |
| pnpm-lock.yaml | Updates lockfile with new dependency versions including lockfile corrections for framer-motion/motion packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "persistent": true | ||
| }, | ||
| "lint": { | ||
| "outputs": [] |
There was a problem hiding this comment.
The turbo.json file is missing a typecheck task configuration, but the package.json includes a typecheck script. For consistency with other apps like apps/web and to ensure proper task caching, consider adding a typecheck task configuration similar to other packages.
| "outputs": [] | |
| "outputs": [] | |
| }, | |
| "typecheck": { | |
| "outputs": [] |
🔗 Linked issue
📚 Description
Summary by CodeRabbit