Skip to content

chore: migrate to use tooling packages#52

Merged
luxass merged 1 commit intomainfrom
luxass/06-09-chore-migrate-to-use-tooling-packages
Jun 9, 2025
Merged

chore: migrate to use tooling packages#52
luxass merged 1 commit intomainfrom
luxass/06-09-chore-migrate-to-use-tooling-packages

Conversation

@luxass
Copy link
Member

@luxass luxass commented Jun 9, 2025

Summary by CodeRabbit

  • Chores
    • Updated TypeScript configuration across multiple packages to use a shared, package-based configuration.
    • Added a new shared TypeScript configuration package for consistent project settings.
    • Adjusted workspace settings to include a new tooling directory.
    • Removed obsolete TypeScript configuration files.

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2025

⚠️ No Changeset found

Latest commit: 5b7cf43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This change migrates TypeScript configuration in several packages to extend from a new shared @ucdjs/tsconfig package, replacing previous relative path extensions. The new config package is added as a development dependency where needed, and workspace configuration is updated to include a new tooling directory. The old base config file is removed.

Changes

File(s) Change Summary
packages/*/package.json Added @ucdjs/tsconfig as a devDependency in cli, schema-gen, ucd-store, and utils packages.
packages/*/tsconfig.json, packages/*/tsconfig.build.json Switched TypeScript config extension from relative paths to @ucdjs/tsconfig/base and /base.build.
pnpm-workspace.yaml Quoted packages/* glob and added "tooling/*" to workspace package globs.
tooling/tsconfig/base.build.json Added new strict TypeScript build config for use as shared base.
tooling/tsconfig/base.json Modified to extend from new base.build.json and updated baseUrl.
tooling/tsconfig/package.json Added new package definition for @ucdjs/tsconfig.
tsconfig.base.build.json Deleted old shared TypeScript build config file.

Sequence Diagram(s)

sequenceDiagram
    participant Package as Package (cli, schema-gen, ucd-store, utils)
    participant TSConfigPkg as @ucdjs/tsconfig
    participant Tooling as tooling/tsconfig

    Package->>TSConfigPkg: Extends base/base.build config
    TSConfigPkg->>Tooling: Loads base.json/base.build.json
    Note right of Package: TypeScript compiler uses shared config from package
Loading

Possibly related PRs

Poem

In the warren, configs hop anew,
Shared tsconfig, a dream come true!
No more paths that twist and wind,
Just one base for all to find.
The bunnies cheer and stamp their feet—
Unified builds are quite a treat!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7d8a03 and 5b7cf43.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (17)
  • packages/cli/package.json (1 hunks)
  • packages/cli/tsconfig.build.json (1 hunks)
  • packages/cli/tsconfig.json (1 hunks)
  • packages/schema-gen/package.json (1 hunks)
  • packages/schema-gen/tsconfig.build.json (1 hunks)
  • packages/schema-gen/tsconfig.json (1 hunks)
  • packages/ucd-store/package.json (1 hunks)
  • packages/ucd-store/tsconfig.build.json (1 hunks)
  • packages/ucd-store/tsconfig.json (1 hunks)
  • packages/utils/package.json (1 hunks)
  • packages/utils/tsconfig.build.json (1 hunks)
  • packages/utils/tsconfig.json (1 hunks)
  • pnpm-workspace.yaml (1 hunks)
  • tooling/tsconfig/base.build.json (1 hunks)
  • tooling/tsconfig/base.json (1 hunks)
  • tooling/tsconfig/package.json (1 hunks)
  • tsconfig.base.build.json (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added pkg: cli Changes related to the CLI package. pkg: schema-gen Changes related to the Schema Gen package. pkg: ucd-store Changes related to the UCD Store package. pkg: utils Changes related to the Utils package. labels Jun 9, 2025
@luxass luxass mentioned this pull request Jun 9, 2025
Copy link
Member Author

luxass commented Jun 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@luxass luxass force-pushed the luxass/06-09-chore-merge-npmrc-setting-into-pnpm-workspace branch from 1fd9a4a to 48dad49 Compare June 9, 2025 13:09
@luxass luxass force-pushed the luxass/06-09-chore-migrate-to-use-tooling-packages branch from 6f0bc3c to b3f6a74 Compare June 9, 2025 13:09
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@luxass luxass changed the base branch from luxass/06-09-chore-merge-npmrc-setting-into-pnpm-workspace to graphite-base/52 June 9, 2025 13:10
@luxass luxass force-pushed the luxass/06-09-chore-migrate-to-use-tooling-packages branch from b3f6a74 to 26cf924 Compare June 9, 2025 13:10
@graphite-app graphite-app bot changed the base branch from graphite-base/52 to main June 9, 2025 13:11
@luxass luxass force-pushed the luxass/06-09-chore-migrate-to-use-tooling-packages branch from 26cf924 to 5b7cf43 Compare June 9, 2025 13:11
@luxass luxass merged commit 0d11b18 into main Jun 9, 2025
3 of 4 checks passed
@luxass luxass deleted the luxass/06-09-chore-migrate-to-use-tooling-packages branch June 9, 2025 13:16
@coderabbitai coderabbitai bot mentioned this pull request Aug 22, 2025
This was referenced Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: cli Changes related to the CLI package. pkg: schema-gen Changes related to the Schema Gen package. pkg: ucd-store Changes related to the UCD Store package. pkg: utils Changes related to the Utils package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant