Merged
Conversation
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
joelridden
reviewed
Oct 22, 2024
requirements.txt
Outdated
| diffimg | ||
| matplotlib | ||
| numpy<2 | ||
| pygmt_helper @ git+https://github.com/ucgmsim/pygmt_helper@cylc |
Contributor
There was a problem hiding this comment.
Can the changes that are needed for these to work be merged for these 2 repos with a PR? That way we can try use main, if not maybe we just write a TODO here to update these once we can get those changes in
Contributor
Author
There was a problem hiding this comment.
I don't actually think that needs to be a cylc branch. It did at some point but I am no longer sure it does.
sungeunbae
reviewed
Oct 23, 2024
AndrewRidden-Harper
previously approved these changes
Oct 24, 2024
joelridden
previously approved these changes
Oct 29, 2024
lispandfound
dismissed stale reviews from joelridden and AndrewRidden-Harper
via
eddf29d
claudio525
reviewed
Oct 30, 2024
Contributor
There was a problem hiding this comment.
I see why you want to rewrite this...
claudio525
previously approved these changes
Oct 30, 2024
lispandfound
requested review from
AndrewRidden-Harper,
claudio525 and
joelridden
joelridden
approved these changes
Nov 4, 2024
AndrewRidden-Harper
approved these changes
Nov 5, 2024
sungeunbae
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module has a few bugs and changes required to merge the new workflow code: