Add rrup_distance and rjb_distance methods to Point, Plane, and Fault classes#13
Merged
lispandfound merged 10 commits intomainfrom Dec 2, 2024
Merged
Add rrup_distance and rjb_distance methods to Point, Plane, and Fault classes#13lispandfound merged 10 commits intomainfrom
lispandfound merged 10 commits intomainfrom
Conversation
… Point, Plane, and Fault classes
….Point and add new hypothesis tests
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
claudio525
reviewed
Nov 18, 2024
Contributor
Author
|
Tests will fail until ucgmsim/qcore#339 merges. |
joelridden
reviewed
Nov 24, 2024
joelridden
approved these changes
Nov 27, 2024
claudio525
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the two most common distance metrics, Rrup and Rjb distance, to the source geometry classes. There is scope for adding Rx at a later date.