Skip to content

Use depth information if dip = 90#18

Merged
lispandfound merged 6 commits intomainfrom
dip
Jan 13, 2025
Merged

Use depth information if dip = 90#18
lispandfound merged 6 commits intomainfrom
dip

Conversation

@lispandfound
Copy link
Copy Markdown
Contributor

This PR changes the behaviour of plane.wgs_depth_coordinates_to_fault_coordinates, which converts WGS84 coordinates to coordinates in the fault.

Old Behaviour

The old behaviour used the corner coordinates of the plane to find the fault local coordinates, without using the depth information. Ignoring the depth is desirable for two reasons:

  1. If dip != 90, then this information is redundant, and removing the depth improves the numerical stability of the linear algebra used to derive the local strike and dip coordinates.
  2. This method is often used for finding converting hypocentre locations to fault local coordinates for simulations. Often the depth is not quite on the plane, or is rounded, which results in errors in the approximation of the fault-local point (see the diagram below).

However, it means that the method fails if dip = 90.

New Behaviour

The new behaviour will now account for the depth of the point in two cases:

  1. When dip = 90,
  2. If the user provides global coordinates with a depth component.

While not passing depth information is supported, depth information
*greatly* improves the accuracy of the estimation. No guarantees
are made about the accuracy of the inversion if you do not pass
depth information.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If depth information is not passed, should this message also be shown in the terminal?

@lispandfound lispandfound merged commit 05445a2 into main Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants