Merged
Conversation
joelridden
reviewed
Jan 12, 2025
| While not passing depth information is supported, depth information | ||
| *greatly* improves the accuracy of the estimation. No guarantees | ||
| are made about the accuracy of the inversion if you do not pass | ||
| depth information. |
Contributor
There was a problem hiding this comment.
If depth information is not passed, should this message also be shown in the terminal?
joelridden
approved these changes
Jan 12, 2025
claudio525
approved these changes
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of
plane.wgs_depth_coordinates_to_fault_coordinates, which converts WGS84 coordinates to coordinates in the fault.Old Behaviour
The old behaviour used the corner coordinates of the plane to find the fault local coordinates, without using the depth information. Ignoring the depth is desirable for two reasons:
dip != 90, then this information is redundant, and removing the depth improves the numerical stability of the linear algebra used to derive the local strike and dip coordinates.However, it means that the method fails if
dip = 90.New Behaviour
The new behaviour will now account for the depth of the point in two cases:
dip = 90,