Add multi-segment parsing capabalities#27
Merged
lispandfound merged 11 commits intomainfrom Feb 10, 2025
Merged
Conversation
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
and removed request for
sungeunbae
Contributor
Author
|
Note to self: I should document the segment behaviour in the class attribute for EDIT: Done! |
Contributor
Author
|
There is some relatively unrelated SRF test coverage code I added to this PR because I noticed that the test coverage didn't include the geometry property of the SRF class. |
Contributor
Author
|
I've updated this PR with the additional capability to extract the velocity model from the FSP file. This is required to investigate the moment allocation among segments from SRCMOD. |
claudio525
approved these changes
Feb 6, 2025
joelridden
approved these changes
Feb 9, 2025
AndrewRidden-Harper
approved these changes
Feb 10, 2025
sungeunbae
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to extract all the segments of an FSP file, by adding a segment column to the dataframe containing the slip model in the FSP file. See list of multi-segment models with TRUP on Slack for examples of these kinds of models.