Add support to read rise time from SRF#30
Merged
lispandfound merged 12 commits intomainfrom Feb 16, 2025
Merged
Conversation
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
Contributor
Author
|
Finally fixed all the geometry test cases, so this is ready for review. |
joelridden
previously approved these changes
Feb 14, 2025
Contributor
Author
|
Sorry @joelridden I just improved some slip tests to make them slightly faster. |
AndrewRidden-Harper
previously approved these changes
Feb 16, 2025
Co-authored-by: AndrewRidden-Harper <52001209+AndrewRidden-Harper@users.noreply.github.com>
AndrewRidden-Harper
approved these changes
Feb 16, 2025
joelridden
approved these changes
Feb 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds SRF parsing support to extract the rise time. This is required for new source modelling plots, it's also just nice to have. It also catches an edge-case for the
.geometryproperty to return ashapely.LineStringinstead of ashapely.Polygonwhendip = 90.