Use sp.integrate.trapezoid instead of np.trapezoid#33
Merged
lispandfound merged 2 commits intomainfrom Feb 21, 2025
Merged
Conversation
lispandfound
changed the title
Contributor
Author
|
Note this is a pretty standard resolution approach to the numpy 2 problem, see e.g. https://gitlab.com/ase/ase/-/merge_requests/3559. |
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
AndrewRidden-Harper
approved these changes
Feb 21, 2025
lispandfound
commented
Feb 21, 2025
Contributor
Author
There was a problem hiding this comment.
This workflow was never supposed to be here. The coverage action is in the pytest file.
sungeunbae
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In migrating to numpy 2, we replaced
np.trapzwithnp.trapezoidbecausenp.trapzwas removed from numpy version 2. However,np.trapezoidwas new to numpy 2, which means the code no longer works with any numpy version except2.x. Obviously, this is not desirable and hence this PR usessp.integrate.trapezoid, which means that the code works with all versions of numpy.