Skip to content

Add function to create Fault object from NHM fault object#40

Merged
claudio525 merged 3 commits intomainfrom
nhm_fault
May 11, 2025
Merged

Add function to create Fault object from NHM fault object#40
claudio525 merged 3 commits intomainfrom
nhm_fault

Conversation

@claudio525
Copy link
Copy Markdown
Contributor

No description provided.

@claudio525 claudio525 marked this pull request as draft April 30, 2025 21:54
@lispandfound
Copy link
Copy Markdown
Contributor

@claudio525 I'd rather see the NHM module be ported to source modelling. It really doesn't belong in qcore.

@lispandfound
Copy link
Copy Markdown
Contributor

lispandfound commented Apr 30, 2025

I would suggest copying the qcore.nhm module to source modelling, and then adding a function to this module geometry_from_nhm_fault that maps an NHMFault to a sources.Fault. I'd prefer not to make the conversion a classmethod of the sources.Fault or sources.Plane because I am trying not to couple these classes to any data sources.

@claudio525 claudio525 marked this pull request as ready for review May 8, 2025 00:26
@claudio525 claudio525 merged commit a2d5ee6 into main May 11, 2025
6 checks passed
@claudio525 claudio525 deleted the nhm_fault branch May 11, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants