Pypi

[claudio525]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @claudio525, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating project metadata and build configurations, likely in preparation for publishing the source-modelling library to PyPI. Key changes include renaming the project, updating author information, refining Python version requirements, and adjusting a core dependency to a more standard package. These modifications aim to streamline the packaging and distribution process.

Highlights

• Project Metadata Update: The project name has been updated from "source_modelling" to "source-modelling", and the author changed from "QuakeCoRE" to "ucgmsim" in pyproject.toml.
• Python Version Specification: The required Python version range has been tightened in pyproject.toml from >=3.11 to >=3.11,<3.14.
• Dependency Management Refinement: The qcore dependency, previously specified via a direct Git URL, has been replaced with qcore-utils in pyproject.toml, suggesting a shift to a more standard package distribution.
• Build Configuration Adjustment: The native flag for the source_modelling.srf_parser extension in setup.py has been set to False, potentially altering its build process for non-native compilation.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/publish-PyPI.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the project configuration to prepare for publishing on PyPI. Key changes include standardizing the package name, updating the author, setting an upper bound for the Python version, and replacing a direct git dependency on qcore with the qcore-utils package from PyPI, which is a great improvement. However, there is a critical issue in setup.py where a build flag for the Rust extension is set incorrectly, which will likely break the package build. I've also included a suggestion to enhance the package metadata in pyproject.toml to improve its discoverability on PyPI.

[Copilot]

Pull request overview

This PR prepares the source-modelling library for publication to PyPI by making necessary configuration changes and adding a GitHub Actions workflow for automated publishing.

Key changes:

• Package name standardized to PyPI conventions (hyphen instead of underscore)
• Git-based dependency replaced with PyPI package (qcore-utils)
• Automated PyPI publishing workflow with trusted publishing (OIDC)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
setup.py	Changed native=False for Rust extension to build universal wheels
pyproject.toml	Updated package name to source-modelling, author to ucgmsim, added Python version upper bound, and replaced git dependency with PyPI package
.github/workflows/publish-PyPI.yml	New workflow for automated PyPI publishing on releases using trusted publishing

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[claudio525]

As discussed with @lispandfound, will ignore the type checking errors for this PR. Jake will fix these in the future.