SRF inspection scripts and helper functions#6
Conversation
lispandfound
requested review from
AndrewRidden-Harper,
claudio525,
joelridden and
sungeunbae
|
these will be useful tools |
|
@joelridden wanted me to add script outputs, I've gone one better and added a wiki page with a reasonably detailed answer to the question "How do I plot x from an SRF?" We can hopefully point PhD students to this page in the future. |
joelridden
left a comment
joelridden
left a comment
There was a problem hiding this comment.
Just a few things, only mentioned the typer app() and title in 1 file but does apply to a few of the scripts. Love the documentation
AndrewRidden-Harper
left a comment
AndrewRidden-Harper
left a comment
There was a problem hiding this comment.
Fantastic documentation!
Co-authored-by: Joel Ridden <33056240+joelridden@users.noreply.github.com>
lispandfound
dismissed stale reviews from claudio525, joelridden, and AndrewRidden-Harper
via
e66d38f
lispandfound
requested review from
AndrewRidden-Harper,
claudio525 and
joelridden
|
Ok this pull is now finally in a good state again. The tests now run because the other PR got merged, and I fixed the coverage issues. There are a couple |
| Parameters | ||
| ---------- | ||
| t : float | ||
| t : array-like |
There was a problem hiding this comment.
Just to check, should this (and others) be array_like or is array-like ok?
AndrewRidden-Harper
left a comment
AndrewRidden-Harper
left a comment
There was a problem hiding this comment.
It looks good. I just want to check that you intended to use array-like instead of array_like?
|
@joelridden All good for you to review now. |
4 participants
I wrote these to plot SRF data for the type-5 verification, but these could be very useful for anyone inspecting an SRF. Requires #4 to work correctly.