generated from ucgmsim/template
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Currently, there are a lot of magic numbers still in existing workflow scripts, and parameters we read from default files in gmsim templates. An example of these defaults is the ds multiplier that caused us issues recently. Because there is no record of these numbers, it can affect our ability to reproduce results. Containers ensure the software is versioned absolutely, and realisations should ensure our parameters are reproducible too. Moreover, if we need to tweak some value from the defaults we currently have to change the code, like the gmsim template. Recording these default parameters in the realistion itself allows us to change them for a rerun too. I would propose the following changes to the workflow to help this:
- Eliminate all default parameter values from all workflow scripts. The biggest offender is currently the HF stage, but there are a couple of things like ds multiplier in the velocity model parameter generation that also need to be eliminated too.
- Record all these values in gmsim templates.
- Add a new workflow stage that loads gmsim defaults and writes them to the realisation.
- All other workflow stages read defaults from the realisation.
This ensures:
- There is a recording of every parameter value used by the workflow. It is archived separately from the container. There is no longer any confusion on what value of the ds multiplier is used for each realisation, because it is recorded in the realisation.
- All default parameters are documented and agreed upon.
- Changing a default value in the event that it is incorrect does not require a rebuild to the containers, we can just change the value in the realisation and rerun.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels