Do not compress broadband waveforms#74
Conversation
Summary of ChangesHello @lispandfound, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the handling of broadband waveforms by removing the lossless compression settings. The author observed that applying compression did not significantly reduce the waveform file size and, conversely, introduced a performance overhead during read operations. By disabling compression, the PR aims to enhance the efficiency and speed of processing these specific data types. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the lossless compression for broadband waveforms when they are saved. According to the description, this change is intended to improve read performance, as the compression did not offer significant file size reduction. The modification in workflow/scripts/bb_sim.py correctly removes the compression and complevel encoding options. The change is straightforward, targeted, and achieves its stated goal. I find no issues with this implementation.
There was a problem hiding this comment.
Pull request overview
This PR removes zlib compression from broadband waveform output to improve read performance. The compression provided minimal storage benefits while significantly slowing down data access. This aligns the broadband output handling with the existing patterns for high-frequency and low-frequency waveform outputs, which also don't use compression. Fletcher-32 checksums are retained to ensure data integrity for long-term storage.
- Removed zlib compression (level 5) from broadband waveform encoding
- Retained Fletcher-32 checksums for data integrity verification
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Small PR that undoes the setting to use lossless compression for broadband waveforms. The waveform does not get meaningfully smaller and makes it slower to read.