Added gitignore to avoid accidentally adding unintended directories #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@SudKul @islamalsawy - Can I ask for a review for this PR and to get it merged ASAP? Many students have been unintentionally committing directories that should not be part of the project completion, and the Github Actions workflow that is set up is failing the Your attention and prompt merge is extremely appreciated. |
Member
|
@rayryeng Thanks for brining this to our attention. Done! |
pjkrupa
pushed a commit
to pjkrupa/Deploying-a-Scalable-ML-Pipeline-with-FastAPI
that referenced
this pull request
Jun 18, 2025
Added gitignore to avoid accidentally adding unintended directories
aericksen-dev
pushed a commit
to aericksen-dev/Deploying-a-Scalable-ML-Pipeline-with-FastAPI
that referenced
this pull request
Oct 1, 2025
Added gitignore to avoid accidentally adding unintended directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
.gitignoreso the student avoids accidentally adding in unintended directories, such asfastapiand.venv, which are part of the setup instructions provided to complete this project.By unintentionally adding these, the
flake8linter test will fail in the Github Actions workflow setup, and the student should not be responsible in fixing the formatting provided by these directories since the student did not author any of them.As such, placing a
.gitignorewill ensure these directories are never added. In addition, I've used the following link to generate other possible directories and files that may get generated during the completion of this project to truly ensure the student doesn't add anything unintended to their commits.