Skip to content

fix: make create mutation input fields optional for beforeCreate hooks #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

fix: make create mutation input fields optional for beforeCreate hooks #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/fix-beforecreate-validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"better-auth-convex": patch
---

Fix beforeCreate hook validation error

Previously, the `create` mutation's input validator required all schema fields to be present, causing validation errors when `beforeCreate` hooks tried to add required fields like `username`.

This fix makes all input fields optional during validation, allowing `beforeCreate` hooks to add or modify any required fields. The actual schema validation still occurs when inserting into the database, ensuring data integrity.
21 changes: 13 additions & 8 deletions src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,14 @@ export const createHandler = async (
beforeCreateHandle?: string;
select?: string[];
onCreateHandle?: string;
skipBeforeHooks?: boolean;
},
schema: Schema,
betterAuthSchema: any
) => {
let data = args.input.data;

if (args.beforeCreateHandle) {
if (!args.skipBeforeHooks && args.beforeCreateHandle) {
const transformedData = await ctx.runMutation(
args.beforeCreateHandle as FunctionHandle<'mutation'>,
{
Expand Down Expand Up @@ -300,6 +301,7 @@ export const deleteOneHandler = async (
};
beforeDeleteHandle?: string;
onDeleteHandle?: string;
skipBeforeHooks?: boolean;
},
schema: Schema,
betterAuthSchema: any
Expand All @@ -312,7 +314,7 @@ export const deleteOneHandler = async (

let hookDoc = doc;

if (args.beforeDeleteHandle) {
if (!args.skipBeforeHooks && args.beforeDeleteHandle) {
const transformedDoc = await ctx.runMutation(
args.beforeDeleteHandle as FunctionHandle<'mutation'>,
{
Expand Down Expand Up @@ -348,6 +350,7 @@ export const deleteManyHandler = async (
paginationOpts: any;
beforeDeleteHandle?: string;
onDeleteHandle?: string;
skipBeforeHooks?: boolean;
},
schema: Schema,
betterAuthSchema: any
Expand All @@ -359,7 +362,7 @@ export const deleteManyHandler = async (
await asyncMap(page, async (doc: any) => {
let hookDoc = doc;

if (args.beforeDeleteHandle) {
if (!args.skipBeforeHooks && args.beforeDeleteHandle) {
const transformedDoc = await ctx.runMutation(
args.beforeDeleteHandle as FunctionHandle<'mutation'>,
{
Expand Down Expand Up @@ -401,12 +404,14 @@ export const createApi = <Schema extends SchemaDefinition<any, any>>(
args: {
beforeCreateHandle: v.optional(v.string()),
input: v.union(
...Object.entries(schema.tables).map(([model, table]) =>
v.object({
data: v.object((table as any).validator.fields),
...Object.entries(schema.tables).map(([model, table]) => {
const fields = partial((table as any).validator.fields);

return v.object({
data: v.object(fields),
model: v.literal(model),
})
)
});
})
),
select: v.optional(v.array(v.string())),
onCreateHandle: v.optional(v.string()),
Expand Down