Skip to content

fix: forward deploy env for migrate and aggregate#229

Merged
zbeyens merged 1 commit into
mainfrom
codex/225-migrate-aggregate-deploy-env
Apr 18, 2026
Merged

fix: forward deploy env for migrate and aggregate#229
zbeyens merged 1 commit into
mainfrom
codex/225-migrate-aggregate-deploy-env

Conversation

@zbeyens
Copy link
Copy Markdown
Member

@zbeyens zbeyens commented Apr 18, 2026

🐛 Fixes #225
🟢 95-100% confidence

Phase 🧪 Tests 🌐 Browser
Reproduced 🔴 ➖ N/A
Verified 🟢 ➖ N/A

✅ Outcome

  • Forward ambient Convex deployment auth env from standalone migrate and aggregate command handlers for prod-target runs.
  • Cover migrate up/status/cancel and aggregate backfill/prune with regression tests.
  • Add a patch changeset for the package release.

🏗️ Design

  • Chosen seam: thread getConvexDeploymentCommandEnv() through standalone command handlers and extend runAggregatePruneFlow() to accept forwarded env.
  • Why not quick patch: fixing only one branch would leave the same regression in sibling standalone paths.
  • Why not broader change: keep createBackendCommandEnv() default wipe intact so local dev/codegen behavior stays unchanged.

🧪 Verified

  • bun test packages/kitcn/src/cli/commands/migrate.test.ts packages/kitcn/src/cli/commands/aggregate.test.ts
  • bun run lint:fix
  • bun run typecheck
  • bun --cwd packages/kitcn build
  • bun run check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 18, 2026

🦋 Changeset detected

Latest commit: a93f264

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
kitcn Patch
@kitcn/resend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
better-convex Ready Ready Preview, Comment Apr 18, 2026 10:59pm

Request Review

@zbeyens zbeyens merged commit 82af4e2 into main Apr 18, 2026
3 checks passed
@zbeyens zbeyens deleted the codex/225-migrate-aggregate-deploy-env branch April 18, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant