Skip to content

Fix auth mutation client typing#245

Merged
zbeyens merged 1 commit into
mainfrom
codex/243-auth-mutations-convex-client
Apr 26, 2026
Merged

Fix auth mutation client typing#245
zbeyens merged 1 commit into
mainfrom
codex/243-auth-mutations-convex-client

Conversation

@zbeyens
Copy link
Copy Markdown
Member

@zbeyens zbeyens commented Apr 26, 2026

  • Auto release

🐛 Fixes #243
🟢 95-100% confidence

Phase 🧪 Tests 🌐 Browser
Reproduced 🔴 Type regression failed with getSession assignability error ➖ N/A
Verified 🟢 Regression passed; bun check green ➖ N/A

✅ Outcome

  • createAuthMutations(authClient) accepts Better Auth clients using convexClient().
  • No user casts.
  • Patch changeset added.
  • Existing Better Auth 1.6 solution note refreshed.
  • Watcher test made deterministic after full gate exposed flake.

⚠️ Caveat

  • No browser surface. TypeScript/package behavior only.

🏗️ Design

  • Chosen seam: createAuthMutations structural auth method boundary.
  • Why not quick patch: casting user auth clients exports package compat debt into app code.
  • Why not broader change: convexClient() runtime shape was right; replacing the auth client surface was unnecessary.

🧪 Verified

  • bun lint:fix
  • bun typecheck
  • bun --cwd packages/kitcn build
  • bun test packages/kitcn/src/react/auth-mutations.types.test.ts packages/kitcn/src/react/auth-mutations.test.tsx
  • bun test packages/kitcn/src/cli/watcher.test.ts -t "startWatcher reacts to a real file change with chokidar v5"
  • bun check

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 26, 2026

🦋 Changeset detected

Latest commit: f946acd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
kitcn Patch
@kitcn/resend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
better-convex Ready Ready Preview, Comment Apr 26, 2026 0:00am

Request Review

@zbeyens zbeyens merged commit 547ccfd into main Apr 26, 2026
7 checks passed
@zbeyens zbeyens deleted the codex/243-auth-mutations-convex-client branch April 26, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

createAuthMutations type error when using convexClient() plugin with better-auth 1.6.x

1 participant