fix auth adoption provider fallback#254
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| Name | Type |
|---|---|
| kitcn | Patch |
| @kitcn/resend | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6aedd3b53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| content: '', | ||
| kind: 'scaffold', | ||
| manualActions: [ | ||
| `Wrap your existing Convex provider with ConvexAuthProvider using src/lib/convex/auth-client.ts, or place the provider at ${normalizedPath} before rerunning auth adoption.`, |
There was a problem hiding this comment.
When convex-provider.tsx is missing, the new manual-action message always tells users to wire src/lib/convex/auth-client.ts, but Start projects without a src/ layout resolve this client under lib/convex (from projectContext.convexClientDir). In that common layout, following this guidance points to a non-existent file and can leave auth wiring broken after a “successful” add run; the message should be derived from the same resolved client directory used elsewhere.
Useful? React with 👍 / 👎.
1 participant
🐛 Fixes local auth preset report
🟢 95-100% confidence
bun checkOutcome
src/lib/convex/convex-provider.tsx; missing provider files now produce a skipped plan entry with manual wiring guidance.authAction, and simple organization writes toctx.orm.bun checknow runsfixtures:check:auto, so fixture package drift is refreshed before the strict fixture comparison.add auth --no-codegenfollowed by explicitkitcn codegen, avoiding the hanging migration path while keeping generated-file validation.Verified
bun test packages/kitcn/src/cli/registry/items/auth/auth-item.test.ts --test-name-pattern "raw Convex Start auth adoption does not require kitcn provider file"failed before the fix, passed after.bun test packages/kitcn/src/cli/registry/items/auth/auth-item.test.tsbun test ./tooling/scenarios.test.tsbun run fixtures:check:autobun run scenario:test -- raw-start-auth-adoptionbun check