fix: repair resend env and schema scaffolds#262
Conversation
Resolve optional Resend env reads through createEnv runtime proxy opt-in. Align Resend table literals with camelCase extension keys. Harden env helper reruns and codex-review helper.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d9bdf17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9bdf17771
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ -z "$final_review_output" ]]; then | ||
| final_review_output=$(cat "$review_output") | ||
| fi | ||
| grep -Eq '^[[:space:]]*-[[:space:]]+\[P[0-3]\]' <<<"$final_review_output" |
There was a problem hiding this comment.
review_output_has_findings only matches lines shaped like - [P1]..., so reviews that emit priorities without a leading dash (for example structured/JSON-derived output) are treated as clean. In that case the helper can print codex-review clean and exit 0 even when actionable findings are present, which weakens the intended review gate for codex-review runs.
Useful? React with 👍 / 👎.
1 participant
🐛 Fixes Resend scaffold env/schema drift
🟢 95-100% confidence
bun checkpassed, including full fixtures and scenario runtime verification.✅ Outcome
getEnv()resolves Convex env-proxy values instead of freezing them asundefined.kitcn add resend.readOptionalRuntimeEnvvalues instead of duplicating or silently dropping keys.codex-reviewhelper no longer points at an author-local path and only parses final review findings.🏗️ Design
createEnvplus scaffold env-helper generation.process.envreads inside Resend would have scattered env ownership and broken the existing generatedgetEnv()contract.🧪 Verified
bun lint:fixbun typecheckbun --cwd packages/kitcn buildgit diff --checkbun test packages/kitcn/src/server/env.test.ts packages/kitcn/src/cli/registry/planner.test.tsbun test ./packages/kitcn/src/cli/cli.commands.ts --test-name-pattern "run\\(add resend\\).*scaffold|ratelimit/auth/resend"CI=1 bun test ./packages/kitcn/src/cli/cli.commands.tsCODEX_REVIEW_AUTO_TESTS=0 .agents/skills/codex-review/scripts/codex-review --mode local --output /tmp/better-convex-codex-review-final.txtbash -n .agents/skills/codex-review/scripts/codex-reviewbun check