fix release workflow trigger#14
Merged
Merged
Conversation
Remove branch filter — the reusable workflow gates on release_branch internally. Add workflow_dispatch for manual triggers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
udx-github
approved these changes
Apr 14, 2026
udx-github
approved these changes
Apr 14, 2026
There was a problem hiding this comment.
Pull request overview
Updates the npm release GitHub Actions workflow triggers so releases can be re-run manually and are no longer limited by a main branch filter (relying on the reusable workflow’s internal release_branch gating).
Changes:
- Removed the
push.branches: [main]filter so the workflow triggers on any push. - Added
workflow_dispatchto allow manual runs/re-triggers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -2,7 +2,7 @@ name: Release | |||
|
|
|||
| on: | |||
| push: | |||
There was a problem hiding this comment.
on: push: is currently configured with a null/empty value. While GitHub Actions often treats this like an unfiltered push trigger, it’s ambiguous and easy to misread. Consider making it explicit (e.g., push: {} or using the short form on: [push, workflow_dispatch]) to avoid YAML/Actions parsing surprises and improve clarity.
Suggested change
| push: | |
| push: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release_branchinternally (matchesudx/worker-deploymentpattern)workflow_dispatchfor manual re-triggersPrevious runs failed with
ENEEDAUTHbecause re-runs inherited stale permissions from before the GitHub environment was created. A fresh push to main will pick up the correctid-token: writepermission.Test plan
🤖 Generated with Claude Code